Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Rotate IAM Keys #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AWS Rotate IAM Keys #4

wants to merge 1 commit into from

Conversation

devopsdymyr
Copy link
Contributor

No description provided.

@miztiik
Copy link
Owner

miztiik commented May 1, 2019

This solution to rotate the keys puts the onus on the developers with no mechanism for enforcement/compliance.
Rather than recommending this solution, we will have just maintain that key rotation should be enforced.

@miztiik miztiik closed this May 7, 2019
@miztiik miztiik reopened this May 11, 2019
miztiik
miztiik reviewed May 11, 2019
View reviewed changes
Copy link
Owner

@miztiik miztiik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some inline comments, Can you please review them add/fix them.

miztiik
miztiik requested changes May 11, 2019
View reviewed changes
Copy link
Owner

@miztiik miztiik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting used to the review functionality,

This package cannot be enforced upon all dev's. For an enterprise, enforcing this and relying solely on dev discretion is not the best way to rotate keys.

Do you have any other recommendations for key rotation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miztiik miztiik miztiik requested changes

Assignees

@devopsdymyr devopsdymyr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devopsdymyr @miztiik